feat(FR-2606): restore BUI i18n context isolation under Vite dep optimization by nowgnuesLee · Pull Request #6870 · lablup/backend.ai-webui

nowgnuesLee · 2026-04-22T05:29:50Z

Summary

Follow-up fix after the initial Vite PoC uncovered that BUI's i18n instance was bleeding into the host app.

Root cause: BUI intentionally maintains its OWN i18n singleton (see BAIConfigProvider's <I18nextProvider i18n={buiI18n}>). Under pnpm's per-package copies (split by TypeScript peer version), the two react-i18next copies had different React Context objects, so BUI's Provider published to its own Context and the host read from its own Context. Clean isolation.

Under Vite's default dep optimizer the two copies were collapsed into a single bundled module → one Context object → BUI's Provider leaked, and host components resolved their keys against BUI's (BUI-only) resource set, rendering raw keys.

Fix: optimizeDeps.exclude: ['i18next', 'react-i18next'] preserves natural pnpm-per-package resolution so the two Context objects stay distinct.

Test plan

Raw i18n keys no longer render on login/dashboard under vite:dev
BUI's own keys still resolve via BUI's Provider
Host's own keys resolve via host's Provider

Stack

Builds on FR-2606 PoC phase 1. Continues the Vite migration series.

nowgnuesLee · 2026-04-22T05:30:03Z

fix(FR-2529): include backend.ai-client src in craco TS loader and tsconfig paths #6615
refactor(FR-2529): extract backend.ai-client as standalone workspace package #6614
fix(FR-2607): align Electron publicPath patch with Vite output #7189
fix(FR-2606): clear residual build-time warnings (BUI dts + module directive) #7113
fix(FR-2606): restore Monaco self-hosting in Vite dev server #7104
feat(FR-2748): fully migrate test files from jest.* to vi.* and align TS globals #7083
feat(FR-2746): re-enable 5 tests skipped during Vitest migration #7071
feat(FR-2744): restore Vitest coverage reporting in CI #7065
fix(FR-2606): replace webpackIgnore with @vite-ignore in dynamic plugin imports #6879
fix(FR-2606): replace global.packageVersion with globalThis.packageVersion in WebUISider #6878
fix(FR-2608): disable vite-plugin-pwa auto-manifest to preserve existing manifest.json #6877
feat(FR-2611): retire Craco/Webpack — build, Makefile, CI all on Vite/Vitest #6876
feat: migrate BUI + root tests from Jest to Vitest (follow-up to FR-2609) #6875
feat(FR-2609): Vitest migration for react/ (100% pass, 856/856 tests) #6874
feat(FR-2608): Vite production build with vite-plugin-pwa service worker #6873
feat(FR-2610): Vite dev-reload plugin for i18n / theme / config.toml file changes #6872
feat(FR-2607): Vite spike answer — es6:// Electron publicPath works via renderBuiltUrl #6871
feat(FR-2606): restore BUI i18n context isolation under Vite dep optimization #6870 👈 (View in Graphite)
feat(FR-2606): Vite PoC phase 1 — dev server + HMR + React Compiler parity #6869
main

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

flow:merge-queue - adds this PR to the back of the merge queue
flow:hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has required the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copilot

Pull request overview

Restores Backend.AI WebUI host-app i18n context isolation from backend.ai-ui under Vite’s dependency optimization, preventing BUI’s I18nextProvider from leaking into the host tree during dev.

Changes:

Exclude i18next / react-i18next from Vite dep optimization to preserve pnpm’s per-package module instances (and thus separate React Contexts).
Add Vite resolve aliases to ESM shim modules for CJS-only transitive deps (void-elements, use-sync-external-store/shim) that would otherwise break when optimization is skipped.
Document the i18n isolation root cause/fix in Vite PoC notes and add a Playwright smoke test as a regression reproducer.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
react/vite.config.ts	Excludes i18n deps from `optimizeDeps` and adds shim aliases; clarifies dedupe intent for other shared singletons.
react/vite-shims/void-elements.mjs	Provides an ESM default-export shim for the CJS-only `void-elements` package.
react/vite-shims/use-sync-external-store-shim.mjs	Provides an ESM shim exporting React’s native `useSyncExternalStore` for the CJS-only shim entrypoint.
react/VITE_POC_NOTES.md	Adds Phase 1 documentation detailing the i18n context isolation issue and the adopted fix.
e2e/vite-poc-smoke.spec.ts	Adds a smoke test intended to guard against the i18n leakage regression during the Vite PoC.

graphite-app · 2026-04-30T12:11:48Z

Merge activity

Apr 30, 12:11 PM UTC: yomybaby added this pull request to the Graphite merge queue.
Apr 30, 12:25 PM UTC: Merged by the Graphite merge queue.

…mization (#6870) Resolves #6809(FR-2606) ## Summary Follow-up fix after the initial Vite PoC uncovered that BUI's i18n instance was bleeding into the host app. **Root cause**: BUI intentionally maintains its OWN i18n singleton (see `BAIConfigProvider`'s `<I18nextProvider i18n={buiI18n}>`). Under pnpm's per-package copies (split by TypeScript peer version), the two `react-i18next` copies had *different* React Context objects, so BUI's Provider published to its own Context and the host read from its own Context. Clean isolation. Under Vite's default dep optimizer the two copies were collapsed into a single bundled module → one Context object → BUI's Provider leaked, and host components resolved their keys against BUI's (BUI-only) resource set, rendering raw keys. **Fix**: `optimizeDeps.exclude: ['i18next', 'react-i18next']` preserves natural pnpm-per-package resolution so the two Context objects stay distinct. ## Test plan - [x] Raw i18n keys no longer render on login/dashboard under `vite:dev` - [x] BUI's own keys still resolve via BUI's Provider - [x] Host's own keys resolve via host's Provider ## Stack Builds on FR-2606 PoC phase 1. Continues the Vite migration series.

github-actions Bot added the size:L 100~500 LoC label Apr 22, 2026

github-actions Bot assigned nowgnuesLee Apr 22, 2026

nowgnuesLee force-pushed the 04-20-feat_fr-2606_vite_poc_phase_1_dev_server_hmr_react_compiler_parity branch from bf0e617 to 7cb1e84 Compare April 27, 2026 13:57

nowgnuesLee force-pushed the 04-20-feat_fr-2606_restore_bui_i18n_context_isolation_under_vite_dep_optimization branch from 5536f7b to 7d337b6 Compare April 27, 2026 13:57

This was referenced Apr 27, 2026

fix(FR-2606): restore Monaco self-hosting in Vite dev server #7104

Merged

fix(FR-2606): clear residual build-time warnings (BUI dts + module directive) #7113

Merged

nowgnuesLee marked this pull request as ready for review April 28, 2026 04:25

Copilot AI review requested due to automatic review settings April 28, 2026 04:25

Copilot started reviewing on behalf of nowgnuesLee April 28, 2026 04:25 View session

Copilot AI reviewed Apr 28, 2026

View reviewed changes

Comment thread e2e/vite-poc-smoke.spec.ts

Comment thread e2e/vite-poc-smoke.spec.ts

Comment thread e2e/vite-poc-smoke.spec.ts

Comment thread e2e/vite-poc-smoke.spec.ts

nowgnuesLee force-pushed the 04-20-feat_fr-2606_vite_poc_phase_1_dev_server_hmr_react_compiler_parity branch from 7cb1e84 to c115607 Compare April 28, 2026 05:02

nowgnuesLee force-pushed the 04-20-feat_fr-2606_restore_bui_i18n_context_isolation_under_vite_dep_optimization branch 2 times, most recently from 5e5dc8f to ef09849 Compare April 28, 2026 05:15

yomybaby mentioned this pull request Apr 30, 2026

fix(FR-2607): align Electron publicPath patch with Vite output #7189

Merged

yomybaby force-pushed the 04-20-feat_fr-2606_restore_bui_i18n_context_isolation_under_vite_dep_optimization branch from ef09849 to 906250d Compare April 30, 2026 12:08

yomybaby force-pushed the 04-20-feat_fr-2606_vite_poc_phase_1_dev_server_hmr_react_compiler_parity branch from c115607 to 7807fa6 Compare April 30, 2026 12:08

This was referenced Apr 30, 2026

refactor(FR-2529): extract backend.ai-client as standalone workspace package #6614

Merged

fix(FR-2529): include backend.ai-client src in craco TS loader and tsconfig paths #6615

Closed

graphite-app Bot force-pushed the 04-20-feat_fr-2606_vite_poc_phase_1_dev_server_hmr_react_compiler_parity branch from 7807fa6 to 4ac49a9 Compare April 30, 2026 12:12

graphite-app Bot force-pushed the 04-20-feat_fr-2606_restore_bui_i18n_context_isolation_under_vite_dep_optimization branch from 906250d to 3e8d20c Compare April 30, 2026 12:13

Base automatically changed from 04-20-feat_fr-2606_vite_poc_phase_1_dev_server_hmr_react_compiler_parity to main April 30, 2026 12:23

graphite-app Bot merged commit 3e8d20c into main Apr 30, 2026
4 checks passed

graphite-app Bot deleted the 04-20-feat_fr-2606_restore_bui_i18n_context_isolation_under_vite_dep_optimization branch April 30, 2026 12:25

github-pages Bot temporarily deployed to github-pages April 30, 2026 12:26 Inactive

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(FR-2606): restore BUI i18n context isolation under Vite dep optimization#6870

feat(FR-2606): restore BUI i18n context isolation under Vite dep optimization#6870
graphite-app[bot] merged 1 commit intomainfrom
04-20-feat_fr-2606_restore_bui_i18n_context_isolation_under_vite_dep_optimization

nowgnuesLee commented Apr 22, 2026 •

edited

Loading

Uh oh!

nowgnuesLee commented Apr 22, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

graphite-app Bot commented Apr 30, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

nowgnuesLee commented Apr 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Stack

Uh oh!

nowgnuesLee commented Apr 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

graphite-app Bot commented Apr 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

nowgnuesLee commented Apr 22, 2026 •

edited

Loading

nowgnuesLee commented Apr 22, 2026 •

edited

Loading

graphite-app Bot commented Apr 30, 2026 •

edited

Loading